Add import-export options for sidebar filters #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeeptarlekar
force-pushed
the
bug/1833/import-export-history
branch
from
42fe38b
to
7d0c16c
Compare
Add ability to import and export all filters, Charts from sidebar. At the moment user can still export all filters from history in toolbar but to enhance the accessibility this PR add same feature in sidebar. Fixes: esrlabs#1833
sudeeptarlekar
force-pushed
the
bug/1833/import-export-history
branch
from
3d804a5
to
339b6bd
Compare
|
Hello @DmitryAstafyev can you please review? Thanks in advance |
DmitryAstafyev
requested changes
Jul 28, 2023
application/client/src/app/ui/views/sidebar/search/providers/providers.ts
Outdated
Show resolved
Hide resolved
application/client/src/app/ui/views/sidebar/search/providers/providers.ts
Outdated
Show resolved
Hide resolved
application/client/src/app/ui/views/sidebar/search/providers/providers.ts
Outdated
Show resolved
Hide resolved
application/client/src/app/ui/views/sidebar/search/providers/providers.ts
Outdated
Show resolved
Hide resolved
application/client/src/app/ui/views/sidebar/search/providers/providers.ts
Outdated
Show resolved
Hide resolved
application/client/src/app/ui/views/sidebar/search/providers/providers.ts
Outdated
Show resolved
Hide resolved
|
In general also in case of an error (import/export) we should inform the user about it. Search via solution be |
sudeeptarlekar
force-pushed
the
bug/1833/import-export-history
branch
from
819b5b8
to
2a648ca
Compare
DmitryAstafyev
requested changes
Jul 31, 2023
Comment on lines
512
to
513
| public contextMenuOptions(items: IMenuItem[]): IMenuItem[] { | ||
| const historySession = history.get(this.session); |
There was a problem hiding this comment.
if return isn't used, it should return void; and name probably should be something like injectGeneralMenuItems. Or if it returns something, it should be getGeneralMenuItems.
Comment on lines
534
to
535
| protected filters(historySession: HistorySession): { import(): void; export(): void } { | ||
| return { |
There was a problem hiding this comment.
method logAndNotifyError can be present as arrow-function here (as soon as it's used only in this scope)
const logAndNotifyError = () => {...};
return {...}
Comment on lines
578
to
579
| protected logAndNotifyError(error: any): void { | ||
| this.logger.error(error.message); |
There was a problem hiding this comment.
Try to reduce from any on client and do not use it.
sudeeptarlekar
force-pushed
the
bug/1833/import-export-history
branch
from
d35e550
to
e5af70a
Compare
DmitryAstafyev
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to import and export all filters, Charts from sidebar. At the moment user can still export all filters from history in toolbar but to enhance the accessibility this PR add same feature in sidebar.
Fixes: #1833